Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling PayPal or Credit Card still shows valued options in the "Recent" section #179

Closed
LaurentShala opened this issue Sep 9, 2019 · 6 comments
Closed

Disabling PayPal or Credit Card still shows valued options in the "Recent" section #179

LaurentShala opened this issue Sep 9, 2019 · 6 comments
Labels
major version

Comments

@LaurentShala
Copy link

General information

  • SDK/Library version: BraintreeDropIn (7.3.0)
  • Environment: Production & Sandbox
  • iOS Version and Device: iOS 12.4 on an iPhone Xs
  • Integration type and version: CocoaPods 1.7.0

Issue description

As a user that has previously vaulted a PayPal payment method,
when I open the Drop-in UI sheet configured with paypalDisabled set to true,
I am still able to see and select my valued PayPal from the "Recent" payment method section.

As a developer, when I set the paypalDisabled on BTDropInRequest to true, I expected for PayPal options to be disabled throughout. Keeping payment methods in the "Recent" sections even though they are disabled can cause confusion for the developer and the user.

Please note this is not specific to PayPal. When setting cardDisabled to true, valued credit cards show up on the "Recent" section as well.

Suggested Solution

When configuring the BTDropInRequest and setting the paypalDisabled to true, I think the valued PayPal payment methods in the "Recent" section should not appear.

See the image below for an example of a BTDropInRequest with paypalDisabled set to true.

Screen Shot 2019-09-09 at 6 30 46 PM
@hollabaq86
Copy link
Contributor

👋 @LaurentShala, thanks for bringing this to our attention.

This is definitely an improvement we can make, but to avoid a breaking change we'll have to add an additional parameter that sets whether vaulted payment methods that are disabled will be shown to the user.

For the next major version, we can drop the extra parameter and make this the default behavior tied to any of the Disabled payment method settings.

@LaurentShala
Copy link
Author

Hello @hollabaq86,

Thank you for your quick reply! Adding an extra parameter will work great. Please keep me in the loop when the next major version is released.

Thanks again!

@GFean
Copy link

GFean commented Feb 1, 2021

Hi there, any updates about this ?

@sestevens
Copy link
Contributor

@RocKer004 This is work we plan to pick up (hopefully soon), but we don't have an exact timeline for it yet. We'll post here when there are updates.

@GFean
Copy link

GFean commented Feb 2, 2021

Hmm.. thanks for your reply, on android it was enough to update to latest version, it means here that's not the case.. well, I'll be waiting for the updates. Thanks

@sestevens sestevens mentioned this issue Apr 1, 2021
Merged
1 task
@sestevens
Copy link
Contributor

This has been fixed in v9. Please see our Migration Guide for steps to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LaurentShala @hollabaq86 @GFean @sestevens